blakeembrey/code-problems

Broken tests?

Open

#118 建立於 2014年6月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (3,818 star) (586 fork)batch import
help wanted

描述

TDD is something I have to take a deeper look, but the tests at least for python are broken. It failed because the test can't find the methods used, which is normal because they aren't imported.

python largest-continuous-sum.py
E
======================================================================
ERROR: test_largest_continuous_sum (__main__.LargestContinousSequenceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "largest-continuous-sum.py", line 5, in test_largest_continuous_sum
    sum = largest_continuous_sum([1, 2, 3, 4])
NameError: global name 'largest_continuous_sum' is not defined

----------------------------------------------------------------------
Ran 1 test in 0.000s

As this is not a package, how we should accomplish this?

貢獻者指南

技術棧
python
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Pythontesting knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
The issue points to the file 'largest continuous sum.py' in the repository 'blakeembrey/code problems'. The test method 'test largest continuous sum' fails because 'largest continuous sum' is not defined or imported. The fix is to import or define the function 'largest continuous sum' in the test file. Check if there is a separate implementation file and import it, or define the function in the same file.