bitwalker/timex

Most functions are incorrect for calendars other than Calendar.ISO

Open

#449 建立於 2018年7月30日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Elixir (1,807 star) (406 fork)batch import
feature/enhancementhelp wantedlevel:advanced

描述

Most functions in Timex manipulate the Elixir data structures directly. In doing so, they assume a lot about the underlying calendar - in most cases the functions would just not work for anything other than Calendar.ISO. The prime example would be Timex.shift/2.

Timex should either amend those functions to be correct in case they are called with other calendars, or pattern match on the value and document the functions to only work with Calendar.ISO.

貢獻者指南

技術棧
elixir
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ElixirTimex libraryCalendar module
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Examine the Timex source code to identify which functions manipulate Elixir data structures directly and assume ISO calendar. Focus on `Timex.shift/2` and similar functions. Check the documentation to see if there are existing guards or pattern matches. Decide whether to add calendar aware implementations or restrict to ISO and update docs accordingly. Consider looking at the `Calendar` module in Elixir for guidance on supporting multiple calendars.