bitovi/funcunit

F.open() doesn't throw when violating same-origin

Open

#156 建立於 2016年8月11日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (575 star) (395 fork)batch import
bughelp wantedp3

描述

You can't, for example, load google.com from localhost. This fails, but does so silently.

We do catch the error in a try/catch here. We could improve this by checking the error in the catch and if it is a SecurityError, rethrow so the user can see the error.

Chrome and Firefox give a different error message, so detecting this might be tricky.

貢獻者指南

技術棧
javascript
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptunderstanding of same origin policy
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue points to the catch block in browser/open.js at line 274. To fix, inspect the caught error object inside catch. In Chrome, SecurityError has name 'SecurityError'; in Firefox, it may have different properties. Use error.name or error.code to detect security violations. Once detected, rethrow the error so the user sees it. Test with a same origin violation scenario (e.g., loading google.com from localhost). No linked PRs or comments exist, so implementation is straightforward.