benoitc/gunicorn

Separate instrumentation and logging

Open

#1,564 建立於 2017年8月6日

在 GitHub 查看
 (9 留言) (4 反應) (0 負責人)Python (9,334 star) (1,707 fork)batch import
Feature/LoggingImprovementhelp wanted

描述

Issues like #1405 demonstrate that having statsd instrumentation built on top of the logging handlers means instrumentation and logging are coupled. Some have found this coupling surprising.

I would like to see proposals for ways to separate these functions.

This may be as simple as making the statsd Logger into a handler instead, so it can be invoked no matter which logger is being used.

貢獻者指南

技術棧
python
領域
backendobservability
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic understanding of gunicorn
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue requests a design to decouple statsd instrumentation from logging handlers in gunicorn. A starting point is to examine the existing statsd integration in gunicorn's handlers (e.g., 'gunicorn.instrument.statsd') and the logging configuration in 'gunicorn.glogging'. The discussion in comments suggests converting the statsd Logger into a separate handler. You should review the referenced issue #1405 and explore the codebase to understand current coupling before proposing a solution.
Separate instrumentation and logging · benoitc/gunicorn#1564 | Good First Issue