beautifier/js-beautify

Beautification problem with JS Single Line Comment <!--

Open

#1,835 建立於 2020年8月31日

在 GitHub 查看
 (9 留言) (0 反應) (1 負責人)JavaScript (8,342 star) (1,460 fork)batch import
good first issuelanguage: javascripttype: bug

描述

In Javascript <!-- is treated as a single-line comment just like //.

js-beautify works as expected when the line starts with <!--:

Input: <!--alert(1)commented

Output: <!--alert(1)commented

Otherwise it will break the syntax:

Input: alert(1)<!--commented

Output: alert(1) < !--commented

貢獻者指南

技術棧
javascript
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic understanding of JavaScript parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the tokenizer or comment handling in js beautify, likely in files like 'js/index.js' or 'core/tokenizer.js'. The issue occurs when `<! ` is not at the start of a line, so the regex or logic that identifies single line comments might need to be extended to include `<! ` as a comment starter. Look at how `//` is handled and add similar handling for `<! `. Check existing tests for comment handling and write a failing test for this case.