beautifier/js-beautify

HTML option "wrap-attributes": "preserve" does not preserve line break before closing angle bracket

Open

#1,707 建立於 2019年9月10日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)JavaScript (8,342 star) (1,460 fork)batch import
good first issuelanguage: htmltype: bug

描述

If you use "wrap-attributes": "force-expand-multiline", you get:

<tag
    attr1="val1"
    attr2="val2"
>content</tag>

The line break before the closing angle bracket is forced with this option.

Now, when you set "wrap-attributes": "preserve", I would expect this formatting to be preserved. However, you get:

<tag
    attr1="val1"
    attr2="val2">content</tag>

Please fix "preserved" or add a new option for keeping the line break before the closing angle bracket.

貢獻者指南

技術棧
javascripthtmlcss
領域
toolingdeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptjs beautify internalsHTML parsing
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the HTML beautifier code in js beautify, likely in `js/lib/beautify html.js`, to understand how 'wrap attributes' options are handled. Look for the logic that distinguishes 'force expand multiline' from 'preserve' regarding line breaks before closing angle brackets. Consider adding a new option or modifying the preserve behavior to retain the line break. Check existing tests in the `test` directory for related test cases.