balderdashy/sails

Preserve async hook on call to helper

Open

#6,960 建立於 2020年3月12日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)JavaScript (22,778 star) (1,953 fork)batch import
help wantedmore info please

描述

So there is this thing called async hooks in Node now that allow for stuff to be preserved like you would with thread local in other languages. A popular library that uses that is cls-hooked. This is very useful to put trace ID and add that trace to the logs when you want to do distributed logging (or add a user ID to have some context for your logs). However, the machine that powers sails messes up with this process and we lose the information when an helper is called. I am not sure what happens, but it is most likely related to how the machine that powers sails works (by making HTTP calls I believe for each helper). I think @mikermcneil would be the one to answer that since not a lot people seem to have touched this code except him...

貢獻者指南

技術棧
javascriptnodejs
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
Node.js async hooksSails MVC framework
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Investigate how the underlying machine module in Sails handles async hooks. The issue suggests that the machine makes HTTP calls for each helper, which may break the async context. Look at the machine's code and any related helper invocation code to understand where the context is lost. Check the 4 comments on the issue for additional clues. Consider reaching out to @mikermcneil for clarification on the intended async hook propagation behavior. Explore whether a fix would involve wrapping helper calls to preserve the async hook context using cls hooked or similar libraries.