badges/shields

DOMParser for dynamic xml badge spews log results in production

Open

#2,658 建立於 2019年1月6日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (22,337 star) (5,423 fork)batch import
good first issueservice-badge

描述

e.g.

@#[line:21,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:22,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:23,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:24,col:1]
[xmldom error]  element parse error: Error: attribute value must after "="
@#[line:47,col:85]
[xmldom error]  element parse error: Error: invalid tagName:\
@#[line:47,col:232]
[xmldom warning]        unclosed xml attribute
@#[line:154,col:7]
[xmldom error]  entity not found: 
@#[line:212,col:143]
[xmldom error]  entity not found: 
@#[line:212,col:143]
[xmldom warning]        unclosed xml attribute
@#[line:299,col:31]
[xmldom warning]        attribute "selected" missed value!! "selected" instead!!
@#[line:342,col:14]
[xmldom error]  entity not found: 
@#[line:379,col:57]
[xmldom error]  entity not found: 

I imagine DOMParser is printing warnings by default. They have a way to provide our own error handler. Maybe we can use that to suppress these messages.

https://github.com/jindw/xmldom#api-reference

貢獻者指南

技術棧
javascriptnodejs
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptfamiliarity with xmldom library
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Look for the DOMParser usage in the dynamic badge generation code in the badges/shields repository. The issue provides a reference to the xmldom API for custom error handlers. Implement a custom error handler that suppresses or ignore the warnings and errors shown in the issue, ensuring production logs are clean. Test that badges still generate correctly.