aws/aws-sdk-pandas

change the name of "mode" argument to awswrangler.s3.to_csv

Open

#2,409 建立於 2023年7月25日

在 GitHub 查看
 (5 留言) (0 反應) (1 負責人)Python (3,560 star) (630 fork)batch import
enhancementhelp wantedinvestigating

描述

Describe the bug

The method (awswrangler.s3.to_csv) supports a "mode" argument and **pandas_kwargs. The "mode" argument is not passed through to Pandas, but consumed in the awswrangler method, which also expects dataset=True to use "mode". In some cases, it would be useful to pass this argument through to Pandas.

If there is already a way to pass "mode" to Pandas, a documentation update would resolve this issue:

How to Reproduce

import awswrangler as wr

...

load a DataFrame and name it df

...

Pandas "mode"

wr.s3.to_csv(df, "some_test_file_name", mode="a", header=False)

awswrangler expects mode="append", dataset=True

Expected behavior

No response

Your project

No response

Screenshots

No response

OS

AWS Lambda x86_64 Architecture

Python version

3.10

AWS SDK for pandas version

3.2.0

Additional context

No response

貢獻者指南

技術棧
pythonpandasaws
領域
datacloud
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonpandasAWS SDK for pandas
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue concerns the awswrangler.s3.to csv function where the 'mode' argument is consumed by the library and not passed to pandas. Review the function signature in the source code (likely in awswrangler/s3/ write csv.py or similar) and the pandas to csv documentation to determine a proper rename (e.g., 'dataset mode' or 'overwrite mode'). Check issue comments for any maintainer guidance. Ensure backward compatibility by adding a deprecation warning for the old argument name.