aws/aws-cdk

(core): Docker stdout is not printed on error during bundling

Open

#20,892 建立於 2022年6月28日

在 GitHub 查看
 (5 留言) (1 反應) (0 負責人)TypeScript (10,710 star) (3,530 fork)batch import
@aws-cdk/assetsbugeffort/smallgood first issuep2package/tools

描述

Describe the bug

In quite a few different scenarios, Docker errors simply happen and "Docker returned 1" gets spat out.

I suspect Docker is writing to stderr but it is getting squashed somewhere.

Expected Behavior

Docker outputs (both stdout and stderr are preserved)

Current Behavior

Docker's error status isn't printed

Reproduction Steps

  • Run cdk synth on a stack that requires docker, but without permissions to talk to Docker's control plane
  • watch as it crashes and burns:
39907defbe84: Pull complete
8f7631647f07: Pull complete
d83e11d24ec9: Pull complete
b09b92bf5cf8: Pull complete
[WARNING] 
software.amazon.jsii.JsiiException: docker exited with status 1
Error: docker exited with status 1
    at dockerExec (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/core/lib/bundling.js:355:15)
    at Function.fromBuild (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/core/lib/bundling.js:243:9)
    at new Bundling (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/bundling.js:28:86)
    at Function.bundle (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/bundling.js:43:50)
    at new PythonFunction (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/function.js:43:39)

The error that is being quashed here was Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/images/create?fromImage=public.ecr.aws%2Fsam%2Fbuild-python3.7&tag=latest": dial unix /var/run/docker.sock: connect: permission denied

貢獻者指南

技術棧
typescriptnodejsdocker
領域
clouddevops
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Node.js child processBasic Docker knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The bug is in the Docker output handling in AWS CDK core. Look at file `packages/@aws cdk/core/lib/bundling.js`, specifically the `dockerExec` function. The issue is that stderr from Docker is not printed on error; only 'docker exited with status 1' is shown. The fix likely involves modifying how child process.execSync or similar captures output. Check comments on the issue for any proposed solutions or maintainer guidance.