avo-hq/avo

field: pass all html options

Open

#3,145 建立於 2024年8月16日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)Ruby (1,778 star) (308 fork)user submission
EnhancementHelp wantedStale exempt

描述

Feature

https://docs.avohq.io/3.0/field-options.html#html only allow for style, classes, or data. It would be great (just as like with mapkick_options for maps) that you pass ALL options to the html field (instead of only the whilelisted ones)

field :name, as: :text, html: {
  edit: {
    wrapper: {
      min: 1,
      max:  100,
      pattern: ...,
    }
}

(sidenote: when this same logic is used within actions, we can also consider https://github.com/avo-hq/avo/issues/2803 closed)

Current workarounds

None

Additional context

This can (amongst other) help to create html validations where relevant

  • min
  • max
  • pattern
  • minlength
  • ...

貢獻者指南

技術棧
ruby
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Ruby on Rails basicsAvo field configurationHTML attributes
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Examine the current implementation of HTML options in the Avo field system, specifically the whitelist logic for allowed attributes. Review the avo codebase for how field options are processed and rendered. Identify where the whitelist is defined and modify it to allow any attribute passed via the html: option. Ensure backward compatibility and update tests accordingly.