avajs/ava

Make line number selection work with TS and JSX syntax

Open

#3,065 建立於 2022年7月10日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (20,600 star) (1,408 fork)batch import
enhancementhelp wantedscope:globbingscope:internalsscope:typescript

描述

Line number selection relies on parsing the test file. This only supports JS syntax:

https://github.com/avajs/ava/blob/ac0d75d05d28e511b1b3654b09d11d602e360179/lib/worker/line-numbers.js#L9-L18

Acorn has a plugin for JSX. If we want to use that we need to decide whether to add it to AVA's dependencies or how else we register it.

There is no plugin for TypeScript. We'd have to work out a solution so that line number selection can work without using @ava/typescript. See https://github.com/avajs/ava/issues/3064 for making it work with @ava/typescript.

貢獻者指南

技術棧
javascripttypescript
領域
testing
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScript parsingAcorn plugin system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current line number selection code in lib/worker/line numbers.js which uses Acorn for JS parsing. Consider adding acorn jsx as a dependency to support JSX syntax. For TypeScript, explore using a lightweight TypeScript parser like @typescript eslint/typescript estree or a separate parsing step. Look at issue #3064 for integration with @ava/typescript. Test the solution with sample files containing TSX and JSX.