avajs/ava

Diffs for arrays of strings can be pretty confusing

Open

#1,521 建立於 2017年9月16日

在 GitHub 查看
 (3 留言) (1 反應) (0 負責人)JavaScript (20,600 star) (1,408 fork)batch import
bughelp wantedscope:assertionsscope:reporters

描述

If you do t.deepEqual (and I think also t.is) on two arrays containing strings. If there are a large amount of strings and they only differ slightly the output is very confusing. It appears that as soon as a new entry in an array has shifted the items after it across, AVA text diffs every single entry against the same index in the original array.

e.g: An array with 219 strings that has had 6 additions and 1 deletion: AVA diff: https://travis-ci.org/lukechilds/window/jobs/266859856 GitHub diff: https://github.com/lukechilds/window/pull/7/commits/6ecbade39561cf705ddc2833cbc3b93e2abfb223

貢獻者指南

技術棧
javascript
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptBasic understanding of AVAFamiliarity with array diff algorithms
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the current diff output logic for arrays in AVA's assertion code, likely in files like lib/assert.js or lib/format diff.js. Analyze the provided examples to understand the alignment issue. Consider implementing a smarter diff that accounts for insertions/deletions rather than index based comparison.