atom/github

Click Staged/Unstaged Changes header to select all files

Open

#1,800 建立於 2018年11月15日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)JavaScript (1,069 star) (469 fork)batch import
good first issuepapercut

描述

In at least couple of user interviews I participated in, the user tried to select all files by clicking the header. This behavior would be consistent with what we have in the ChangedFileItem where clicking a hunk header highlights all the changed lines in the hunk

貢獻者指南

技術棧
javascript
領域
frontenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Atom package developmentBasic knowledge of Git staging UI
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the Click handling in the ChangedFileItem component (likely in packages/github/lib/views/ changed file item.js) to see how hunk header clicks select all lines. Then apply similar logic to the Staged/Unstaged Changes header components (e.g., staged changes view and unstaged changes view). The issue mentions that users expect clicking the header to select all files, so look at the header's click event and implement a handler that checks all file checkboxes within that section.