atom/github

Replace getDerivedStateFromProps with memoization

Open

#1,611 建立於 2018年7月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (1,069 star) (469 fork)batch import
code-cleanup :wrench:good first issue

描述

Where possible, it would be cleaner and less error-prone to replace components that implement static getDerivedStateFromProps() with PureComponents or memoize-one:

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of memoization
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Search the codebase for components that implement the getDerivedStateFromProps lifecycle method. In each case, evaluate whether the derived state can be computed using memoization with memoize one or by converting to a PureComponent. Follow the guidance in the linked React blog post. Ensure test coverage for the affected components. Since the issue is from 2018, verify that the components still exist and the pattern is still applicable.
Replace getDerivedStateFromProps with memoization · atom/github#1611 | Good First Issue