apple/swift-nio

NIOLoopBound should get `unchecked` variants that are truly free in release mode

Open

#2,506 建立於 2023年8月17日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Swift (8,453 star) (749 fork)batch import
good first issuekind/enhancement

描述

NIOLoopBound(Box) is super useful when adopting Sendable but the eventLoop.preconditionInEventLoop() checks everywhere are expensive and -- for repeated accesses -- unnecessary.

There should be unchecked variants of init, get and set value that do eventLoop.assertInEventLoop() instead. Together with @inlinable that should become completely free in release mode (and still check in debug).

Docs:

貢獻者指南

技術棧
swift
領域
backendperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Swift concurrencyNIOLoopBound APIassert vs precondition
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The implementation should add new initializers and methods to `NIOLoopBound` and `NIOLoopBoundBox` in the NIO module. The issue suggests using `assertInEventLoop` instead of `preconditionInEventLoop` in the unchecked variants, and marking them with `@inlinable` for release mode optimization. Contributors should review the existing implementation at the provided documentation links and consider any thread safety implications.