apple/swift-nio

ClientBootstrap.resolver is hard to use for single-use resolvers

Open

#2,434 建立於 2023年5月26日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Swift (749 fork)batch import
good first issuekind/enhancement

倉庫指標

Star
 (8,453 star)
PR 合併指標
 (平均合併 9天 10小時) (30 天內合併 15 個 PR)

描述

Some resolvers (like NIO's internal GAIResolver) are use-exactly-once objects. They work only if used once (not 0 times, not twice).

ClientBootstrap.resolver is hard to use with those objects because one might want to pass around a pre-configured ClientBootstrap and then not use it or use it multiple times.

Maybe ClientBootstrap could offer a resolverFactory method that gets invoked exactly when we actually do the resolution.

The other option would that NIO could provide a Resolver type that wraps use-once resolvers and managed their lifetime (creates a fresh one when a resolution actually happens).

貢獻者指南