apache/pinot

Inconsistent segment file extension for TarGzPush and MetadataPush

Open

#10,375 建立於 2023年3月3日

在 GitHub 查看
 (6 留言) (0 反應) (1 負責人)Java (1,234 fork)batch import
good first issue

倉庫指標

Star
 (4,937 star)
PR 合併指標
 (平均合併 6天 7小時) (30 天內合併 186 個 PR)

描述

Our SegmentGenerationJobRunner adds tar.gz extension to the segment file name.

  • TarGzPush: the controller side segment upload logic removes tar.gzextension when copying data to deep storage. The segment file will be stored as fileName.
  • MetadataPush: we use pinotFS to copy file from local to dst. Segment file will be stored as fileName.tar.gz.

It's going to be good if we can make the name convension the same. But, this will change the file name convension to the deepstorage. We should at least consider to add the config to remove the extension to have the clear migration path. (e.g. some people can start the cluster using TarGzPush and want to migrate to MetadataPush and keep the file names the same convention in the deep storage)

貢獻者指南