apache/openwhisk

"Too many concurrent requests in flight" error message is misleading

Open

#4,798 建立於 2020年1月12日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Scala (1,177 fork)batch import
good first issue

倉庫指標

Star
 (6,777 star)
PR 合併指標
 (平均合併 17小時 31分鐘) (30 天內合併 3 個 PR)

描述

@ali-raza-tariq commented on Fri Jan 10 2020

The existing implementation shows the following error message when inflight limit is exceeded

<Response [429]> b'{\n  "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n  "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'

Few suggestions:

The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)

So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)

貢獻者指南