apache/openwhisk

"Too many concurrent requests in flight" error message is misleading

Open

#4,798 建立於 2020年1月12日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Scala (6,777 star) (1,177 fork)batch import
good first issue

描述

@ali-raza-tariq commented on Fri Jan 10 2020

The existing implementation shows the following error message when inflight limit is exceeded

<Response [429]> b'{\n  "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n  "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'

Few suggestions:

The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)

So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)

貢獻者指南

技術棧
scala
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic understanding of OpenWhisk architectureScala
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The error message is generated in the controller code, likely in the file that handles concurrency limits (e.g., LoadBalancer or ActivationThrottle). The issue suggests changing the 'allowed' field to reflect the user set actionInvokesConcurrent limit or total allowed across controllers. A fix should update the error message string to clarify that the allowed count is per controller, or compute the total allowed. The variable 'allowed' is currently set to the per controller limit; a better approach might be to display both per controller and total limits. Since there are no linked PRs or comments, maintainer input is needed to confirm the desired approach.