apache/openwhisk

do not base64 encode __ow_body for raw web actions

Open

#3,920 建立於 2018年7月30日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Scala (6,777 star) (1,177 fork)batch import
controllergood first issuehelp wanted

描述

#3919 removes the base64 encoding requirement when returning JSON as string (and setting the content-type). However we continue to encode JSON for raw http actions receiving __ow_body. For symmetry, we should stop doing that as well. This is largely in place for legacy reasons (spray vs akka). The net of this change is that functions would JSON.parse(param.__ow_body) instead of JSON.parse(decode64(param.__ow_body)).

貢獻者指南

技術棧
無
領域
backendcloud
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understand OpenWhisk action encodingFamiliarity with raw web actions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue references PR #3919 that removed base64 encoding for JSON responses. The goal is to similarly remove base64 encoding for raw web actions' ow body. Look at the code handling raw HTTP actions, likely in the same area as the previous change. The comment mentions spray vs akka legacy reasons, so the change might be in the routing or serialization layer. Search for 'base64' or 'decode64' in the codebase related to ` ow body`.