apache/gravitino

[Improvement] Remove warnings when compiling Gravitino

Open

#1,809 建立於 2024年1月31日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Java (887 fork)auto 404
good first issueimprovement

倉庫指標

Star
 (3,058 star)
PR 合併指標
 (PR 指標待抓取)

描述

What would you like to be improved?

Warning shows up when compiling Gravitino, adding -Xlint:unchecked gives this:

> Task :common:compileJava FAILED
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:82: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(metalake.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:132: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(catalog.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:141: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(schema.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/util/DTOConverters.java:167: warning: [unchecked] unchecked call to withProperties(Map<String,String>) as a member of the raw type Builder
        .withProperties(table.properties())
                       ^
  where S is a type-variable:
    S extends Builder declared in class Builder
error: warnings found and -Werror specified
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:90: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:101: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/AuditDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/MetalakeDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:112: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:123: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:134: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:145: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:156: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/CatalogDTO.java:167: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:86: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:97: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:108: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/SchemaDTO.java:119: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:141: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:152: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:163: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:174: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:185: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/ColumnDTO.java:190: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:164: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:175: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:186: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:197: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:208: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:213: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:218: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:223: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/TableDTO.java:228: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:93: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:98: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
/Users/justin/gravitino/common/src/main/java/com/datastrato/gravitino/dto/rel/indexes/IndexDTO.java:103: warning: [unchecked] unchecked cast
      return (S) this;
                 ^
  required: S
  found:    Builder<S>
  where S is a type-variable:
    S extends Builder declared in class Builder
1 error
40 warnings

How should we improve?

Remove the warnings. This is required by https://www.bestpractices.dev/en

貢獻者指南

研究方向
在 DTOConverters.java 和 DTO 文件（AuditDTO、MetalakeDTO、CatalogDTO、SchemaDTO、ColumnDTO、TableDTO、IndexDTO）中為 Builder 類別添加泛型類型參數，以消除未檢查警告。確保 withProperties 方法和類型轉換語句使用正確的泛型類型。
技術棧
java
領域
backend
議題類型
重構
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1 小時以內
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
活躍
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
清晰
前置要求
JavaGenerics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80