apache/dubbo

[CodeReview 3.0] Dubbo in spring

Open

#8,633 建立於 2021年8月29日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Java (26,453 fork)batch import
help wanted

倉庫指標

Star
 (41,524 star)
PR 合併指標
 (平均合併 7天 14小時) (30 天內合併 20 個 PR)

描述

1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.

DubboConfigConfigurationRegistrar only has one function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);
}

but DubboComponentScanRegistrar also has this function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);

    Set<String> packagesToScan = getPackagesToScan(importingClassMetadata);

    registerServiceAnnotationPostProcessor(packagesToScan, registry);
}

貢獻者指南