apache/brpc

thrift支持时，编译出错

Open

#1,328 建立於 2021年1月10日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C++ (16,226 star) (3,936 fork)batch import
buggood first issue

描述

Describe the bug (描述bug) 开启thrift，cmake -B build -DWITH_THRIFT=ON编译出错

/usr/local/include/thrift/protocol/TBinaryProtocol.h:38:7: note: candidate: ‘apache::thrift::protocol::TBinaryProtocolTapache::thrift::transport::TMemoryBuffer::TBinaryProtocolT(apache::thrift::protocol::TBinaryProtocolTapache::thrift::transport::TMemoryBuffer&&)’ /usr/local/include/thrift/protocol/TBinaryProtocol.h:38:7: note: no known conversion for argument 1 from ‘boost::shared_ptrapache::thrift::transport::TMemoryBuffer’ to ‘apache::thrift::protocol::TBinaryProtocolTapache::thrift::transport::TMemoryBuffer&&’ /mnt/e/ormosiaVM/github/Asty/Asty-platform-server/thirdparty/incubator-brpc/src/brpc/policy/thrift_protocol.cpp: In function ‘void brpc::policy::SerializeThriftRequest(butil::IOBuf*, brpc::Controller*, const google::protobuf::Message*)’: /mnt/e/ormosiaVM/github/Asty/Asty-platform-server/thirdparty/incubator-brpc/src/brpc/policy/thrift_protocol.cpp:673:110 error: no matching function for call to ‘apache::thrift::protocol::TBinaryProtocolTapache::thrift::transport::TMemoryBuffer::TBinaryProtocolT(boost::shared_ptrapache::thrift::transport::TMemoryBuffer&)’ 673 | apache::thrift::protocol::TBinaryProtocolTapache::thrift::transport::TMemoryBuffer oprot(out_buffer); | ^ In file included from /mnt/e/ormosiaVM/github/Asty/Asty-platform-server/thirdparty/incubator-brpc/src/brpc/policy/thrift_protocol.cpp:39: /usr/local/include/thrift/protocol/TBinaryProtocol.h:52:3: note: candidate: ‘apache::thrift::protocol::TBinaryProtocolT<Transport_, ByteOrder_>::TBinaryProtocolT(std::shared_ptr<Tp>, int32_t, int32_t, bool, bool) [with Transport = apache::thrift::transport::TMemoryBuffer; ByteOrder_ = apache::thrift::protocol::TNetworkBigEndian; int32_t = int]’ 52 | TBinaryProtocolT(std::shared_ptr<Transport_> trans, | ^~~~~~~~~~~~~~~~ /usr/local/include/thrift/protocol/TBinaryProtocol.h:52:3: note: candidate expects 5 arguments, 1 provided

To Reproduce (复现方法) 开启thrift，cmake -B build -DWITH_THRIFT=ON编译出错

Expected behavior (期望行为)

Versions (各种版本) OS:WSL2 ubuntu20.04 Compiler:gcc version 9.3.0 (Ubuntu 9.3.0-10ubuntu2) brpc: commit b226c34b019223d6f59dbde892ad59f6740a2439 (HEAD -> master, origin/master, origin/HEAD) Merge: b34b776c ba5d932d Author: Jiashun Zhu zhujiashun2010@gmail.com Date: Thu Jan 7 19:25:17 2021 +0100

Additional context/screenshots (更多上下文/截图)

貢獻者指南

技術棧
cpp
領域
build system
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
C++ThriftCMakebrpc build setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the compilation error in `src/brpc/policy/thrift protocol.cpp` at line 673. The issue is that the `TBinaryProtocolT` constructor expects a `std::shared ptr` but receives a `boost::shared ptr`. Check the version of Apache Thrift installed and determine if there is an API change. Look for any existing workarounds or patches in the brpc repository or related discussions. Consider updating the code to use `std::shared ptr` or conditionally compile based on thrift version.