apache/beam

PipelineOptions getters can produce null even if not annotated Nullable when no Default is specified

Open

#21,363 建立於 2022年6月4日

在 GitHub 查看
 (4 留言) (0 反應) (2 負責人)Java (7,313 star) (4,097 fork)batch import
P2bugcoregood first issuejava

描述

Context: BEAM-13537, https://github.com/apache/beam/pull/16625#discussion_r793021931

PipelineOptions getters without Default specified can produce null, but because it happens in generated code, the null checker will not complain about it. Is there some way we can make sure getters without a Default are always Nullable?

Imported from Jira BEAM-13758. Original Jira may contain additional context. Reported by: bhulette.

貢獻者指南

技術棧
java
領域
backenddata
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Java programmingFamiliarity with Apache Beam's PipelineOptions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the PipelineOptions interface and its generated implementation to understand how getters without @Default are handled. Look at the code generator (probably AutoValue or similar) to see if @Nullable can be automatically added when no Default is specified. Check the referenced PR #16625 discussion for context on the nullability issue.