apache/beam

Migrate common_job_properties.groovy to use Maps for keyword argument style calls instead of positional arguments

Open

#18,768 建立於 2022年6月3日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Java (7,313 star) (4,097 fork)batch import
P3good first issueimprovementtests

描述

This follows the the style defined within build_rules.gradle as it is much simpler to read the following method with keyword arguments: setCommonJobProperties(context: context, maxWorkers: 3)

This also simplifies the usage of methods with multiple default arguments.

Imported from Jira BEAM-4235. Original Jira may contain additional context. Reported by: lcwik.

貢獻者指南

技術棧
groovy
領域
developer experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Groovy language fundamentalsFamiliarity with Apache Beam project structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine common job properties.groovy in the repository to identify all function calls that use positional arguments. Refer to the style guide in build rules.gradle (line 397) for the target keyword argument style using maps. Update each call accordingly, ensuring default arguments are handled correctly. No linked PRs or comments exist, so confirm with maintainers if the change is still wanted before proceeding.