apache/airflow

IMAP hook silently overwrites attachments with identical filenames

Open

#65,870 建立於 2026年4月26日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Python (44,809 star) (16,781 fork)batch import
area:providersgood first issuekind:bugprovider:imap

描述

Under which category would you file this issue?

Providers

Apache Airflow version

3.2.1

What happened and how to reproduce it?

Problem

When using imap_hook.download_mail_attachments, attachments with identical filenames are saved to disk using the same name, which leads to silent overwriting of previously downloaded files.

This results in data loss without any warning, and there is currently no option to control this behavior.

How to reproduce

  1. Receive multiple emails with attachments sharing the same filename (e.g. report.xlsx)
  2. Call imap_hook.download_mail_attachments
  3. Inspect the output directory
  4. Observe that only one file is present, as earlier files were overwritten

What you think should happen instead?

There should be a configurable way to control how filename collisions are handled when saving attachments, for example:

  • either allow overwriting existing files
  • or preserve all files by automatically renaming them.

The current behavior should not be hardcoded without user control.

Possible improvement

Introduce a configurable parameter (e.g. overwrite_file or similar) that controls collision handling behavior:

  • overwrite_file=True → overwrite existing files (current behavior)
  • overwrite_file=False → preserve all files

This would make the behavior explicit and safe for different use cases.

Operating System

No response

Deployment

Official Apache Airflow Helm Chart

Apache Airflow Provider(s)

imap

Versions of Apache Airflow Providers

apache-airflow-providers-imap==3.11.0

Official Helm Chart version

Not Applicable

Kubernetes Version

No response

Helm Chart configuration

No response

Docker Image customizations

No response

Anything else?

A previous implementation attempt and discussion can be found here:

https://github.com/apache/airflow/pull/62321

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

貢獻者指南

技術棧
python
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonApache Airflow basicsFile I/O
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests a configurable parameter for handling filename collisions when saving attachments from IMAP. A previous attempt is referenced in PR #62321, which can be reviewed for implementation insights. The main file to modify is likely `airflow/providers/imap/hooks/imap.py`, specifically the `download mail attachments` method. Consider adding an `overwrite` keyword argument (default True to preserve current behavior) and using a renaming strategy (e.g., appending a counter) when `overwrite=False`. The maintainer's feedback on the PR should be consulted to align with project standards.