apache/airflow
在 GitHub 查看Don't have session.commit() when @provide_session decorator is used
Open
#12,818 建立於 2020年12月4日
area:MetaDBcontributors-workshopgood first issuekind:taskpriority:medium
倉庫指標
- Star
- (44,809 star)
- PR 合併指標
- (平均合併 7天 18小時) (30 天內合併 834 個 PR)
描述
As discussed in https://github.com/apache/airflow/pull/12815#discussion_r536283503 and pointed out at https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#database-session-handling, we should not have session.commit() when @provide_session decorator is used (for principle "Explicit is better than implicit").
This issue exists in files like https://github.com/apache/airflow/blob/2936c13a44369daae9d6099cd1070b3a8cd53443/airflow/models/dag.py (and some more of course)