ant-design/ant-design

Accessibility: Focus on invisible div in tabs while tabbing

Open

#49,680 建立於 2024年7月2日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (98,031 star) (54,612 fork)batch import
Inactivehelp wanted⌨️ Accessibility

描述

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Select first tab
  2. Use 'Tab' key to move focus
  3. Focus is lost after moving past last tab because it is focused on hidden div element

What is expected?

Focus should move between interactive elements, and should not disappear at any point

What is actually happening?

Focus visually disappears when landing on the non-interactive and invisible hidden div

Environment Info
antd 5.19.0
React 18.3.1
System Windows 10 Enterprise
Browser Google Chrome: version 126.0.6478.127

antd version: 5.19.0 (I couldn't select version so I put it here) The same issue is here: https://ant.design/components/tabs also it is the same issue like for modal here: https://github.com/react-component/dialog/issues/429

貢獻者指南

技術棧
typescriptreactcss
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactaccessibility fundamentalsant design Tabs componentfocus management
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Focus on the ant design Tabs component source code, specifically the keyboard navigation logic. Look at how focus is managed when tabbing through tabs. The issue is that focus lands on a hidden div, so ensure that non interactive hidden elements are not focusable. Reference the linked issue in react component/dialog for a similar fix. Check the files under `components/tabs/src/` for relevant code.