ant-design/ant-design

Modal 下 destroyOnClose 属性 失效

Open

#28,847 建立於 2021年1月13日

在 GitHub 查看
 (5 留言) (2 反應) (0 負責人)TypeScript (98,031 star) (54,612 fork)batch import
Inactivehelp wanted🐛 Bug

描述

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://fvrw0.csb.app/

Steps to reproduce

modal下使用video标签，播放后，关闭modal video or audio标签依然播放， 且重新打开modal 依然存在

What is expected?

modal关闭后销毁媒体标签

What is actually happening?

modal关闭后未销毁标签

Environment Info
antd 4.10.2
React 16.12.0
System win10
Browser firefox

貢獻者指南

技術棧
typescriptreacthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Reactantd Modal componentcomponent lifecycle
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue is that the Modal's destroyOnClose prop does not destroy media elements (like video) when the modal closes. Investigate the Modal component in the antd repository, likely in components/modal/Modal.tsx, to understand how destroyOnClose is implemented. Check if the issue is related to React's unmounting behavior or conditional rendering. The reproduction link shows the problem, so replicate it. Look at the component's state management and ensure that when destroyOnClose is true, the child components are properly unmounted (e.g., using a key prop or conditional rendering). Also check if there are any existing comments or maintainer responses that hint at a solution.
Modal 下 destroyOnClose 属性 失效 · ant-design/ant-design#28847 | Good First Issue