ansible/awx

Fix Delinea imports and import test

Open

#14,703 建立於 2023年12月5日

在 GitHub 查看
 (3 留言) (0 反應) (1 負責人)Python (13,071 star) (3,333 fork)batch import
blockedcomponent:apigood first issuetype:bug

描述

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

DomainPasswordGrantAuthorizer is unused in awx/main/credential_plugins/tss.py. Flake8 will most likely catch this on the next run so just want to get ahead of this.

awx/main/tests/functional/test_credential_plugins.py will also need to be adjusted for its removal.

AWX version

devel

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

N/A

Modifications

no

Ansible version

n/a

Operating system

n/a

Web browser

No response

Steps to reproduce

Run flake8 and functional tests locally, they will fail with unused imports.

Expected results

Tests pass without issue.

Actual results

ImportError: cannot import name 'DomainPasswordGrantAuthorizer' from 'awx.main.credential_plugins.tss' (/awx_devel/awx/main/credential_plugins/tss.py) or an unused import: DomainPasswordGrantAuthorizer is imported but not used will show up

Additional information

We can remove the try except block now as well if we want as the requirements file has been updated. I will pick this up if no one from the community wants to take it up

貢獻者指南

技術棧
python
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Pythonpytestbasic AWX project structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue involves removing the unused import of `DomainPasswordGrantAuthorizer` in `awx/main/credential plugins/tss.py` and adjusting the test in `awx/main/tests/functional/test credential plugins.py` accordingly. The issue author mentioned they can also remove the try except block if desired. Review the flake8 output and run functional tests to verify the fix. Look at the file history for the tss.py to understand the context of the import.