ansible/awx

Improve Slack Notification Error Handling

Open

#1,048 建立於 2018年1月24日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (13,071 star) (3,333 fork)batch import
Hacktoberfestcomponent:apicomponent:uigood first issuetype:enhancement

描述

ISSUE TYPE
  • Enhancement
COMPONENT NAME
  • API
  • UI
SUMMARY

Currently we only surface errors when sending slack notification if a Python exception occurs. We could do better if we read the event stream after our rtm_send_message call to see if there were any error events waiting.

A common error is when the bot has not been invited to a channel that we are attempting to send the notification to. This can be caught in the message stream, but does not throw an exception.

ADDITIONAL INFORMATION

https://github.com/ansible/awx/blob/devel/awx/main/notifications/slack_backend.py#L49

貢獻者指南

技術棧
python
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonSlack RTM APIAWX notification system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the Slack RTM API documentation and the existing code in awx/main/notifications/slack backend.py, specifically the rtm send message method. Investigate how to read the event stream after sending a message to catch errors like 'not in channel'. Implement error handling that logs or surfaces these errors appropriately.
Improve Slack Notification Error Handling · ansible/awx#1048 | Good First Issue