ankidroid/Anki-Android

DialogHandler assumes it was started by DeckPicker, may crash otherwise

Open

#5,075 建立於 2018年10月21日

在 GitHub 查看
 (18 留言) (0 反應) (1 負責人)Kotlin (11,132 star) (2,789 fork)batch import
2.8.x2.9.xBugHelp WantedKeep OpenPriority-HighRelease process

描述

Reproduction Steps
  1. Open AnkiDroid via a Reviewer-first pathway?
  2. request file import?
Expected Result

Import dialog is shown

Actual Result

ClassCastException because import dialog is spawned from Reviewer somehow, instead of DeckPicker?

java.lang.ClassCastException: com.ichi2.anki.Reviewer cannot be cast to com.ichi2.anki.DeckPicker
at com.ichi2.anki.dialogs.DialogHandler.handleMessage(DialogHandler.java:82)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6501)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

貢獻者指南

技術棧
kotlinandroid
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Android development basicsUnderstanding of AnkiDroid's DeckPicker and Reviewer
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate DialogHandler.handleMessage() in DialogHandler.java. The crash occurs because it assumes the activity is DeckPicker. Consider checking if the activity is an instance of DeckPicker or Reviewer, or redesign the dialog creation to be context independent. Review the call chain from imports to understand how DialogHandler is invoked from Reviewer. Look at issue comments for any suggested fixes.