angular/components

mat-icon has display issues when inlining multiple copies of the same SVG with defs with IDs

Open

#9,529 建立於 2018年1月23日

在 GitHub 查看
 (4 留言) (4 反應) (0 負責人)TypeScript (24,044 star) (6,650 fork)batch import
P4area: material/iconhelp wanted

描述

Bug, feature request, or proposal:

Proposal: Extend the cloneSvg function in src/lib/icon/icon-registry.ts to accommodate munging IDs in defs so that multiple copies of the same inlined SVG won't have conflicting IDs.

What is the expected behavior?

When two copies of an SVG with a linearGradient def (identified by an ID) are inlined, both copies of the SVG should display the linear gradient.

What is the current behavior?

Only the first copy of the SVG displays the linear gradient. All other copies do not, because the IDs in the defs are duplicated in the other copies.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 5.1.2, Angular Material 5.0.2 (although the issue still exists in 5.1.0), TypeScript 2.6.2. Tested in Win10 in Chrome Version 63.0.3239.132 (Official Build) (64-bit).

貢獻者指南

技術棧
angulartypescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Angular Material basicsTypeScriptSVG defsicon registry.ts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the cloneSvg function in src/lib/icon/icon registry.ts. Understand how SVGs are currently cloned and where IDs are duplicated. Consider appending unique suffixes to IDs in defs for each cloned SVG copy. Check existing tests and verify behavior.