angular/components

chips: SPACE separator does not work with virtual keyboards on Android

Open

#9,237 建立於 2018年1月4日

在 GitHub 查看
 (12 留言) (10 反應) (0 負責人)TypeScript (24,044 star) (6,650 fork)batch import
P3androidarea: material/chipshelp wanted

描述

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Separate chips on space when SPACE is set in MatChipInput.matChipInputSeparatorKeyCodes

What is the current behavior?

On Android devices it does not. (I personally tried Nesus X5 and pixel xl v1)

What are the steps to reproduce?

https://stackblitz.com/edit/chipinput "android friendly chip input" uses keyup and looks at the last char of the input's value, to get around Android's "bad" keyboard event w/o keys and indistinguishable keycode 229.

What is the use-case or motivation for changing an existing behavior?

To be able to use MatChipInput on Android.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All but on Android devices

Is there anything else we should know?

Android produces keycode 229 on space and other special characters. Related to https://stackoverflow.com/questions/36753548/keycode-on-android-is-always-229/42552368

貢獻者指南

技術棧
typescriptjavascripthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Angular MaterialTypeScriptkeyboard events
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Focus on the MatChipInput directive in the chips module. The current implementation uses keydown event with keyCode. For Android (keyCode 229), switch to keyup event and compare the input value's last character to detect space. Check the StackBlitz example mentioned for reference. Ensure the fix does not break existing behavior on desktop.