angular/components

Changing the value of one progress bar repaints other progress bars on the same page

Open

#19,873 建立於 2020年7月6日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)TypeScript (24,044 star) (6,650 fork)batch import
P4area: material/progress-barhelp wanted

描述

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/angular-dc63ug?file=src%2Fapp%2Fprogress-bar-determinate-example.html

Steps to reproduce:

  1. Open the url in latest chrome
  2. Open dev tool and click three dots, click more tools, add Rendering tab, select paint flashing checkbox there
  3. Now go back to demo url and change the value of second progress bar by typing in the second input box (from top)
  4. while changing any value you will observe the beneath progress bar is also repainting

Expected Behavior

What behavior were you expecting to see? Changing the value of one progress bar should not re-paint the other progress bar on the same page

Actual Behavior

What behavior did you actually see? Changing the value of one progress re-painting the other progress bar on the same page

Environment

  • Angular:8.2
  • CDK/Material:8.2.3
  • Browser(s): Chrome - 83.0.4103.116
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

貢獻者指南

技術棧
typescripthtmlcss
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Angular change detectionZone.js
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is reproducible in the provided StackBlitz. Investigate the progress bar component in `src/lib/progress bar/` directory. The repaint occurs because Angular's default change detection triggers updates on all progress bars when one changes. Consider using `OnPush` change detection or detaching change detection for individual progress bars.