angular-ui/ui-grid

selectAllVisibleRows() should be selecting only the current page rows

Open

#6,479 建立於 2017年11月26日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

In the case of client side paginated data, selectAll button action should be selecting only current page rows. Also when pages are navigated, the selectAll button should be deselected.

Is this a bug or an intended feature? In selectAllVisibleRows, shouldnt grid.getVisibleRows() be iterated instead of grid.rows?

貢獻者指南

技術棧
angularjavascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Angular basicsui grid APIpagination concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Review the `selectAllVisibleRows` implementation in the ui grid source code (likely in `src/features/selection/`). Compare usage of `grid.rows` vs `grid.getVisibleRows()` and confirm that the pagination logic distinguishes visible rows. Test the fix with client side pagination enabled to ensure only current page rows are selected. Also verify that the selectAll button state resets on page change.
selectAllVisibleRows() should be selecting only the current page rows · angular-ui/ui-grid#6479 | Good First Issue