angular-ui/ui-grid

getTotalPages() is working wrong for Custom pagination

Open

#6,246 建立於 2017年6月2日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (2,496 fork)batch import
good first issue

倉庫指標

Star
 (5,395 star)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

Hi guys, In this Pagination api method below

getTotalPages: function () { if (!grid.options.enablePagination) { return null; } if (grid.options.useCustomPagination) { return grid.options.paginationPageSizes.length; } return (grid.options.totalItems === 0) ? 1 : Math.ceil(grid.options.totalItems / grid.options.paginationPageSize); }

in this part:

if (grid.options.useCustomPagination) { return grid.options.paginationPageSizes.length; }

It brokes the pagination, since it will never return the real quantity of pages to use, but the quantity in the pageSizes array ....

貢獻者指南