angular-ui/ui-grid

Removing a row when all are expanded, everything will collapse leaving the button as "-" (expanded)

Open

#6,032 建立於 2017年2月21日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

I have a grid with 2 levels with expandable options and delete rows for the first level grid. After delete any row, the data is reloaded, its ok if everything is collapsed, the issue is : the button is showing "-" instead of "+" Steps:

  1. Expand all rows image
  2. Delete 1 row image
  3. The grid is reloaded and the button is "-" image

Plunker: http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview

貢獻者指南

技術棧
javascriptangular
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic familiarity with AngularJSUnderstanding of ui grid expand/collapse
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
The issue involves a state inconsistency when deleting a row after expanding all rows. Investigate the Plunker link (http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview) and the ui grid source code, particularly the expand/collapse toggle logic and the data reload mechanism after deletion. Look at how the grid resets the expand state when the data changes. The bug likely lies in the toggle state not being re evaluated after the grid data is refreshed.