angular-ui/ui-grid

Sorting doesn't work with cellFilter and customTreeAggregationFinalizerFn for 'number'

Open

#5,405 建立於 2016年5月16日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

http://ui-grid.info/docs/#/tutorial/209_grouping

In the tutorials there is an example for doing a cellFilter for 'Balance' that will still work for aggregation. It's not apparent from the provided data (since they are all in the thousand range), but sorting doesn't work correctly for that column. It sorts it in lexicographical order instead of numerical order. I've tried with the number filter in angular as well.

I tried adding the type: 'number', which makes the sorting work, but breaks the aggregation total.

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptAngularJSui grid
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the ui grid source code, particularly the grouping and sorting modules. Look at how cell filters and custom aggregation functions interact with the column type. The issue is that adding type: 'number' fixes sorting but breaks aggregation; understand why and find a solution that maintains both. Check the main grid source files such as src/features/grouping and src/features/sort. Also consider the use of the cellFilter parameter in gridOptions.