angular-ui/ui-grid

GridRenderContainer.prototype.getMargin seems to to slowdown apps

Open

#4,909 建立於 2015年12月27日

在 GitHub 查看
 (0 留言) (2 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
help wantedseverity: performance

描述

I profiled one of my apps with Batarang. i noticed that for a page with six smaller ui grid instances the GridRenderContainer.prototype.getMargin takes about 60% of the cpu time.

The method is called from a template:

$templateCache.put('ui-grid/uiGridRenderContainer', ...{ 'margin-left': colContainer.getMargin('left') + 'px', 'margin-right': colContainer.getMargin('right') + 'px' }...

The function loops over viewportAdjusters. Maybe it is worthwhile to optimize the method. For example, it filters out the adjustment results of many of the calls made:

if (adjustment.side && adjustment.side === side)

Such calls could be avoided. Or maybe there is a way to cache the margins and avoid the loop altogether.

貢獻者指南

技術棧
javascriptangular
領域
frontend
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptAngularJSPerformance profiling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the `getMargin` method in `GridRenderContainer` prototype. The method loops over `viewportAdjusters` and filters by side. Consider caching margins or optimizing the loop. Look at the template in `ui grid/uiGridRenderContainer` where `getMargin` is called twice for left and right. Check if `viewportAdjusters` can be filtered before iteration.