angular-ui/ui-grid

column resizing when filtering creates new set of comments in HTML DOM on each key pressed

Open

#4,672 建立於 2015年11月11日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
help wantedseverity: performance

描述

This plunk: http://plnkr.co/edit/vMaDCAbJMc2nSC59qVkT

Try filtering Gender column... Inspect DOM in Chrome (for example) under div role="columnheader" of that column, a lot of HTML comments are added, like this <!-- ngIf: grid.options.enableColumnResizing -->

On each keystroke, a new set of comments is added.

DOM manipulation such as this slows browsers

貢獻者指南

技術棧
javascriptangular
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Angular ngIfDOM inspection
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Reproduce the issue using the provided Plunkr. Inspect the DOM to verify the excess comment nodes. Look into the column resizing directive in the ui grid source (likely in files like 'ui grid column resizing' or related). The comments are generated by ngIf, suggesting the resizing directive is toggling visibility repeatedly on each keystroke. Investigate the filter logic that triggers re rendering and identify the cause of repeated ngIf evaluations. Consider whether a track by or one time binding could prevent unnecessary DOM updates.