good first issue
倉庫指標
- Star
- (5,395 star)
- PR 合併指標
- (30 天內沒有已合併 PR)
描述
Version 3.0.7 of ui-grid.js line number 3139
This function is (obviously) assuming that it will ever be called with two objects, but it also gets called with the length of the columnDefs collection changes which causes it to crash on line 3142 because self.grid.options.columnDefs gets assigned n, which is a number.
I'm not sure if this is the complete fix, but checking for typeof n !== 'number' seems to fix the problem.
function columnDefsWatchFunction(n, o) {
if (n && n !== o && typeof n !== 'number' ) {
self.grid.options.columnDefs = n;
self.grid.buildColumns({ orderByColumnDefs: true })
.then(function(){
self.grid.preCompileCellTemplates();
self.grid.callDataChangeCallbacks(uiGridConstants.dataChange.COLUMN);
});
}
}