angular-ui/ui-grid

Invalid arguments provided in click handler of selectionSelectAllButtons & treeBaseExpandAllButtons

Open

#4,551 建立於 2015年10月20日

在 GitHub 查看
 (0 留言) (0 反應) (1 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issuegrid-selection

描述

Hi,

there is a bug in the ui-grid/selectionSelectAllButtons template or its directive: the click handler in directive uiGridSelectionSelectAllButtons is expecting 2 arguments:

$scope.headerButtonClick = function(row, evt) { }

but only the $event argument is provided, resulting in a wrongly assigned argument (i.e. event is passed as the row argument). You should either fix the template or modify the directive. The same goes for the uiGridTreeBaseExpandAllButtons directive btw.

NB I suggest you modify the templates to

ng-click="headerButtonClick(null, $event)"

because then you keep your code in line with the other templates (e.g. selectionRowHeaderButtons.html)

貢獻者指南