angular-ui/ui-grid

Selected row count in grid footer not updated when rows deleted programmatically

Open

#4,100 建立於 2015年8月3日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issuetype: bugworkaround

描述

Deleting gird rows with gridOptions.data.splice does not update girdFooter selected row counts.

See http://plnkr.co/edit/a7GogUdI5nDUvc2KN1Rt?p=preview

Example is a fork of Tutorial: 210 Selection.

$scope.deleteSelected = function() {
      var rowsToDelete;
      rowsToDelete = $scope.gridApi.selection.getSelectedRows();
      if (rowsToDelete.length) {
        rowEntity = rowsToDelete[0];
        rowIndexToDelete = $scope.gridOptions.data.indexOf(rowEntity);
        $scope.gridOptions.data.splice(rowIndexToDelete, 1);
      }
   }

Steps to reproduce

  1. select row
  2. press 'Delete selected row' button, which fires $scope.deleteSelected
  3. footer still indicates deleted row is selected (selected row count does not decrement)

Before

plunker

After

plunker

貢獻者指南

技術棧
javascriptangular
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
AngularJS basicsui grid selection API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate why the grid footer's selected row count is not updated when rows are deleted programmatically using splice. The issue is that splicing gridOptions.data does not trigger the grid's internal selection update. Look at the selection module in ui grid (likely in src/features/selection/) to understand how selected row counts are tracked and updated. The solution may involve using the grid API's deleteRow method or calling gridApi.selection.validateSelection() after data mutation. The plunker linked in the issue provides a reproduction. See if there are any existing tests or PRs related to this.