Remove 'replace' from directives · angular-ui/ui-grid#4024

2015-07-21T20:31:41.000Z

Two major reasons: - It is deprecated and will be removed in Angular 2.0 https://docs.angularjs.org/api/ng/service/$compile - It creates more problems than it is worth. - For example: If you try to create a stacked directive and start adding classes to an element they end up getting removed because the dom element gets removed.

(0 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import

good first issueneeds: decisiontype: enhancement

描述

Two major reasons:

It is deprecated and will be removed in Angular 2.0 https://docs.angularjs.org/api/ng/service/$compile
It creates more problems than it is worth.
- For example: If you try to create a stacked directive and start adding classes to an element they end up getting removed because the dom element gets removed.

貢獻者指南

技術棧: javascriptangular
領域: frontend
議題類型: refactor
難度: 2
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: AngularJSDirectives
新手友善度: 50
研究方向: This issue involves removing the deprecated 'replace' property from all AngularJS directive definitions in the ui grid codebase. Look for occurrences of 'replace: true' or 'replace: false' in directive definition objects. Ensure tests are updated accordingly. The issue is from 2015, so verify if the codebase still uses AngularJS version that supports it. Refer to the AngularJS documentation on $compile for context.