angular-ui/ui-grid

Refactor removed ability to handle Enter & arrow keys on grid

Open

#3,805 建立於 2015年6月18日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Refactor: https://github.com/angular-ui/ng-grid/pull/3120 says this:

The problem is that viewPortKeyDown does not get called for navigation keystrokes (specifically Enter and Left/Right Arrow). Previous to this refactor, we could attach an ng-keydown in a cell template to handle these keys.

We desperately need this, as the Enter key lets us submit the form the user is on and the left/right arrow keys let us scroll the grid immediately, irrespective of which column has focus.

I can try to submit a bug fix if that's preferred, though I might not implement it properly...

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptAngularJSui grid codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the refactor in PR #3120 which changed key event handling. Look at the cellNav feature code in source/features/cellnav/ directory, particularly how viewPortKeyDown is implemented and why it doesn't fire for navigation keys like Enter and arrows. Compare with the old behavior where ng keydown in cell templates was used. Consider extending viewPortKeyDown to include these keys or provide a new API.