angular-fullstack/generator-angular-fullstack

Enhancement: Remove serve-favicon dependency

Open

#2,640 建立於 2017年9月28日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (6,134 star) (1,268 fork)batch import
Help Wantedchoreenhancement

描述

The philosophy behind the serve-favicon module is rather outdated, almost nobody knows or cares about creating .ico files. Everyone just puts .png or .gif files now (Mac and iOS ignore .ico anyway). But omitting the favicon.ico file makes the app crash in production environment because of the serve-favicon dependency.

Please consider removing this module and adding support for the modern icons required by the newer OSs, by adding these lines in _index.html:

  <link rel="icon" type="image/png" href="/favicon.png">
  <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="96x96" href="/favicon-96x96.png">
  <link rel="apple-touch-icon" href="/favicon_120_retina.png">
  <link rel="apple-touch-icon" sizes="152x152" href="/favicon_152_retina.png">
  <link rel="apple-touch-icon" sizes="167x167" href="/favicon_167.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/favicon_180.png">

貢獻者指南

技術棧
javascriptnodejsexpressangularhtmlcss
領域
frontendbackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic HTML knowledgeNode.js project structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue requires removing the serve favicon dependency from the project's package.json and updating the index.html to include the provided favicon link tags. The file index.html is likely in the app's template directory. No linked PRs or comments indicate any ongoing work. The main task is to update the template and configuration.