andreypopp/react-css-components

Allow className prop to apply classes to components

Open

#13 建立於 2016年7月13日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (676 star) (23 fork)batch import
enhancementhelp wanted

描述

At the moment, if you import a component from your CSS, using the className prop to pass global classes in doesn't seem to work.

Is there a way to make these carry through to the underlying markup to allow things like global layout classes?

貢獻者指南

技術棧
reactcssjavascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactCSS ModulesProp forwarding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue requests that the `className` prop be forwarded to the underlying DOM elements. Investigate the component implementation in `src/`, likely using CSS Modules, to see how classes are currently applied. Ensure that the passed `className` is merged with the module's generated class. Review existing tests and update them to cover this case. Check for any breaking changes or edge cases with multiple class names.