Crash when clicking away BitWarden safe dialog · andOTP/andOTP#406

(1 留言) (0 反應) (1 負責人)Java (3,711 star) (368 fork)batch import

bughelp wantedupdate-required

描述

General information

App version: 0.6.3.1-play
App source: Google Play / F-Droid / GitHub / ... Google Play
Android Version: 9
Custom ROM: ThouchWiz

Expected result

What is expected? no crash

What does happen instead? crash

Logcat

10-23 15:08:53.556 E/AndroidRuntime(19809): Process: org.shadowice.flocke.andotp, PID: 19809
10-23 15:08:53.556 E/AndroidRuntime(19809): 	at org.shadowice.flocke.andotp.View.EntriesCardAdapter.updateLastUsed(EntriesCardAdapter.java:348)
10-23 15:08:53.556 E/AndroidRuntime(19809): 	at org.shadowice.flocke.andotp.View.EntriesCardAdapter.hideEntry(EntriesCardAdapter.java:291)
10-23 15:08:53.556 E/AndroidRuntime(19809): 	at org.shadowice.flocke.andotp.View.EntriesCardAdapter.access$800(EntriesCardAdapter.java:74)
10-23 15:08:53.556 E/AndroidRuntime(19809): 	at org.shadowice.flocke.andotp.View.EntriesCardAdapter$1$1.run(EntriesCardAdapter.java:245)

Steps to reproduce

open app
enter pin
click somewhere except on the BitWarden safe dialog
andOTP crashes

貢獻者指南

技術棧: javaandroid
領域: mobilesecurity
議題類型: bug
難度: 3
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Android developmentJava
新手友善度: 60
研究方向: Focus on EntriesCardAdapter.java, specifically the hideEntry method (line 291) and updateLastUsed method (line 348). The crash occurs when clicking away from the BitWarden safe dialog, likely due to a null object. Investigate what the safe dialog is and how its dismissal triggers hideEntry. Check if there's a missing null check or if the adapter's state is inconsistent. Look at the code around line 245 in the runnable to understand the threading. Reproduce the crash and add a null check for the affected object.