alvarcarto/url-to-pdf-api

scrollPage bug

Open

#52 建立於 2018年1月2日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)HTML (6,967 star) (759 fork)batch import
PR welcomehelp wanted

描述

There are some websites such as example using a special lazy loading strategy.

When users scroll quickly(<300ms) they do not load image. Just when users stop to look at the content they load image.

So, I think that we need another option (scrollInterval) to let user to test and decide the interval.

releated discussions:

https://github.com/GoogleChrome/puppeteer/issues/338#issuecomment-333301117

Thanks!

貢獻者指南

技術棧
javascriptnodejs
領域
backendapi
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of PuppeteerNode.js development environment
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the existing scrollPage implementation in the codebase, likely in a Puppeteer script. Look for where the scrolling logic is handled, and consider adding a new option `scrollInterval` that introduces a delay between scrolls. Reference the related discussion linked (https://github.com/GoogleChrome/puppeteer/issues/338#issuecomment 333301117) for implementation details. Test with the provided example website to ensure images load with the new option.